refactor ExcludedFromBuild to use Conditional properly - #8794
Closed
IOBYTE wants to merge 3 commits into
Closed
Conversation
Collaborator
Author
|
I'm going to close this now. I think I finally found the root cause of all the dead end problems I keep encountering while trying to extend this code. We are evaluating condition wrong. We are parsing the file and then evaluating the conditions per configuration. We should be parsing for configurations and then parsing the file per configuration. This is how msbuild does it. The result is similar but we wouldn't have to have all the special code looking for known variables and the ones we don't look for will just start working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.