Remove valueFlowArrayBool() (redundancy with valueFlowImpossibleValues())

[chrchr-github]

No description provided.

[danmar]

This is an AI review. Take it with a grain of salt and feel free to reject it by resolving the comment.

The removal looks safe to me. I built the PR and compared it with main on a set of array-to-bool cases (if (buf), if (!buf), bool b = buf;, buf && x, while (buf), buf ? 1 : 2, struct member arrays s->a / s.a) and on samples/, test/cfg/ and a couple of lib/ files with --check-level=exhaustive. The warnings are identical.

One suggestion: valueFlowArrayBool() had explicit handling for a pointer whose tok-value is an array (the isTokValue branch). That case still works after this PR, but I could not find a test covering it in testcondition.cpp. Maybe add a regression test so this doesn't silently break later, for example:

check("void f() {\n"
      "    char buf[10];\n"
      "    char *p = buf;\n"
      "    if (!p) {}\n"
      "}\n");
ASSERT_EQUALS("[test.cpp:4:9]: (style) Condition '!p' is always false [knownConditionTrueFalse]\n", errout_str());