TS-46436 improve log messages#903
Open
karottenreibe wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
DreierF
requested changes
May 22, 2026
| LOG.severe { | ||
| "Cannot resolve the feature classpath for ${descriptor}. This is probably a bug. Please report to CQSE" | ||
| "Cannot resolve the feature classpath for Cucumber test descriptor '${descriptor.displayName}'." + | ||
| " Please report a bug" + |
Contributor
There was a problem hiding this comment.
the to CQSE somehow got lost here
| throw new RuntimeException( | ||
| "Reflection failed to access internal Instruction.predecessor field." | ||
| + " This usually means the bundled JaCoCo version was upgraded without updating this class." | ||
| + " Please report a bug.", |
| if (classesDirectories.isEmpty()) { | ||
| logger.warn("No class directories found for caching.") | ||
| logger.warn( | ||
| "No class directories provided — testwise coverage will be calculated with out caching." |
Contributor
There was a problem hiding this comment.
Suggested change
| "No class directories provided — testwise coverage will be calculated with out caching." | |
| "No class directories provided — testwise coverage will be calculated without caching." |
|
|
||
| private fun missingServerPropertyMessage(property: String, example: String) = | ||
| "Teamscale server '$property' must not be empty." + | ||
| " Set it via 'teamscale { server { $property.set(\"$example\") } }' in your build.gradle.kts." |
Contributor
There was a problem hiding this comment.
Suggested change
| " Set it via 'teamscale { server { $property.set(\"$example\") } }' in your build.gradle.kts." | |
| " Set it via 'teamscale { server { $property = \"$example\" } }' in your build.gradle.kts." |
| - PATCH version when you make backwards compatible bug fixes. | ||
|
|
||
| # Next version | ||
| - [security fix] _agent_: The Azure shared-key error messages no longer include the configured `azure-key` value in the exception text (previously leaked the access key into stack traces and logs) |
Contributor
There was a problem hiding this comment.
Should we mention that we improved the log messages? (no strong preference from my side)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-46436
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.