Add support for a multistep readiness hook workflow#75
Merged
damsallem merged 5 commits intocriteo:mainfrom Jan 13, 2026
Merged
Add support for a multistep readiness hook workflow#75damsallem merged 5 commits intocriteo:mainfrom
damsallem merged 5 commits intocriteo:mainfrom
Conversation
jeremy-clerc
force-pushed
the
dissociatedhooks
branch
6 times, most recently
from
7707b59 to
64c810e
Compare
Contributor
|
I know it's WIP but some comments anyway! |
jeremy-clerc
force-pushed
the
dissociatedhooks
branch
from
64c810e to
4666d47
Compare
Contributor
Author
Not sure if my forced push removed your comments, but I do not have them in my emails either. Left todo:
|
jeremy-clerc
changed the title
geobeau
reviewed
Dec 3, 2025
Contributor
No it's me, I don't know how to use a computer! |
jeremy-clerc
force-pushed
the
dissociatedhooks
branch
from
4666d47 to
0aee930
Compare
jeremy-clerc
changed the title
damsallem
approved these changes
Jan 12, 2026
Contributor
damsallem
left a comment
damsallem
left a comment
There was a problem hiding this comment.
Sounds good to me, there are iteration to be done to properly publish metrics (I see in v2 we don't care yet about observability), but to test first manager with new API, it shall be enough and the existing one is not supposed to be broken !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.