Skip to content

Remove leftover playground constants and bump the SDK #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcospassos merged 2 commits into from
Aug 26, 2026
Merged

Remove leftover playground constants and bump the SDK #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24f55c0
Remove leftover playground constants
marcospassos Aug 26, 2026
640b449
Bump SDK to 0.22.4
marcospassos Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/deploy-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
run: |-
rm -rf build
npm run bundle -- --config-cdn-url=${CDN_URL} \
--config-playground-origin=${PLAYGROUND_ORIGIN} \
--config-playground-connect-url=${PLAYGROUND_CONNECT_URL} \
--config-preview-widget-origin=${PREVIEW_WIDGET_ORIGIN} \
--config-preview-widget-url=${PREVIEW_WIDGET_URL}

Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"dependencies": {
"@croct/content": "^1.1.0",
"@croct/json": "^2.1.0",
"@croct/sdk": "^0.22.0",
"@croct/sdk": "^0.22.4",
"tslib": "^2.7.0"
},
"devDependencies": {
Expand Down
5 changes: 0 additions & 5 deletions release-config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@
import {pathToFileURL} from 'url';

const CDN_ORIGIN = 'https://cdn.croct.io';
const PLAYGROUND_ORIGIN = 'https://play.croct.com';

/**
* The environment variable that exposes each constant to the workflows.
*/
const VARIABLES = {
cdnUrl: 'CDN_URL',
playgroundOrigin: 'PLAYGROUND_ORIGIN',
playgroundConnectUrl: 'PLAYGROUND_CONNECT_URL',
previewWidgetOrigin: 'PREVIEW_WIDGET_ORIGIN',
previewWidgetUrl: 'PREVIEW_WIDGET_URL',
};
Expand All @@ -35,8 +32,6 @@ export function getWidgetPath(version) {
export function getConstants(version) {
return {
cdnUrl: `${CDN_ORIGIN}/js/v1/lib/plug.js`,
playgroundOrigin: PLAYGROUND_ORIGIN,
playgroundConnectUrl: `${PLAYGROUND_ORIGIN}/connect.html`,
previewWidgetOrigin: CDN_ORIGIN,
previewWidgetUrl: `${CDN_ORIGIN}/${getWidgetPath(version)}`,
};
Expand Down
10 changes: 0 additions & 10 deletions rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,6 @@ export default args => {
throw new Error('The argument "config-cdn-url" is missing.');
}

if (args['config-playground-origin'] === undefined) {
throw new Error('The argument "config-playground-origin" is missing.');
}

if (args['config-playground-connect-url'] === undefined) {
throw new Error('The argument "config-playground-connect-url" is missing.');
}

if (args['config-preview-widget-origin'] === undefined) {
throw new Error('The argument "config-preview-widget-origin" is missing.');
}
Expand Down Expand Up @@ -50,8 +42,6 @@ export default args => {
preventAssignment: true,
delimiters: ['<@', '@>'],
cdnUrl: args['config-cdn-url'],
playgroundOrigin: args['config-playground-origin'],
playgroundConnectUrl: args['config-playground-connect-url'],
previewWidgetOrigin: args['config-preview-widget-origin'],
previewWidgetUrl: args['config-preview-widget-url'],
}),
Expand Down
2 changes: 0 additions & 2 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export const CDN_URL = '<@cdnUrl@>';
export const PLAYGROUND_ORIGIN = '<@playgroundOrigin@>';
export const PLAYGROUND_CONNECT_URL = '<@playgroundConnectUrl@>';
export const PREVIEW_WIDGET_ORIGIN = '<@previewWidgetOrigin@>';
export const PREVIEW_WIDGET_URL = '<@previewWidgetUrl@>';
Loading