Open
Conversation
Tests exercise icalendar_proposals with nil event_type, nil time, and nil room — all of which currently raise NoMethodError.
Skip events with nil time or event_type in icalendar_proposals, and use safe navigation for room name to avoid NoMethodError when generating .ics calendar exports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
in legacy 2021 conference data).
Include screenshots, videos, etc.
Who authored this PR?
@sikesbc
How should this PR be tested?
venue, and valid events.
generate iCal output without errors instead of raising NoMethodError.
Are there any complications to deploying this?