loading the asset from the local filesystem if available.

[strfn]

No description provided.

[tsheaff]

What problem does this solve? Shouldn't you know if the URLs you're passing in are local or remote on the initializer. Or perhaps I'm missing something.

[strfn]

This is so the player streams the media from the local filesystem instead of the network if the file is available.

[tsheaff]

@strfn Yeah it's an option. But it feels like it's not the job of this library. It's a streaming library. If you aren't streaming, several of the properties and methods may not act as you expect. For example, is timeBuffered gonna return 1 in this case, or 0, or something else? And I don't think persistentStreamPlayerDidLoadAsset will ever be called.

This also slows things down slightly on the main thread for the typical case of streaming remotely (fileExistsAtPath needs to go to disk).

You can just do this file check outside the PersistentStreamPlayer if you want, and use AVPlayerItem directly in that case, because the interface to PersistentStreamPlayer was not designed or tested for playing local audio.

Let me know if I'm wrong about this or if you have tested this more thoroughly. I can sympathize with wanting to use the same library in the disk AND network case. At minimum there should be a new BOOL property on the header that indicates if it's reading from disk not network.