Conversation
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Looks good! One minor comment inline.
|
@sfowl Looks good from upstream point of view. Please note that we (in fact you) still build I can see a successful build of |
It seems %cmake4 macros are no longer provided in rawhide, nor is there a `Provides: cmake4`. For now we still need the ability to build for EPEL7, where unversioned cmake will resolve to v2, so conditionally we still use v3. https://fedoraproject.org/wiki/Changes/CMake4.0
Very good point, I overlooked this. For now I think we need to keep the ability to build for epel7, so I've added conditional use of cmak3 vs cmake. EDIT: I re-requested review because this change is significant |
kdudka
left a comment
kdudka
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the update!
3 participants
It seems %cmake4 macros are no longer provided in
rawhide, nor is there a
Provides: cmake4.https://fedoraproject.org/wiki/Changes/CMake4.0