Fix views made with whitespace-only names (D1060)#592
Merged
Conversation
Contributor
|
Thanks Pawel, this looks great. I think it would just be worth adjusting the error message slightly, maybe to say "View name must not contain only whitespace characters"? |
droberts-ctrlo
pushed a commit
to droberts-ctrlo/GADS
that referenced
this pull request
Feb 9, 2026
* Fix views made with whitespace-only names * Update error message to improve clarity --------- Co-authored-by: Pawel <p.wlodarski@ctrlo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regex statement checks if the view name consists of just whitespace characters.
If true, it throws an error to the user.