V11/refactor out test steps fake#1855
Open
luke-hill wants to merge 5 commits intov11/remove_fake_queryfrom
Open
V11/refactor out test steps fake#1855luke-hill wants to merge 5 commits intov11/remove_fake_queryfrom
luke-hill wants to merge 5 commits intov11/remove_fake_queryfrom
Conversation
luke-hill
commented
Apr 9, 2026
| test_step_finished: Cucumber::Messages::TestStepFinished.new( | ||
| test_step_id: event.test_step.id, | ||
| test_case_started_id: test_case_started_id(test_case), | ||
| test_case_started_id: find_test_case_started_by_test_case.id, |
Contributor
Author
There was a problem hiding this comment.
This causes the breakage in rerun formatter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Much smaller attempt to remove one "fake query" ivar from the message builder class.
This also has an added benefit of removing 2 calls to the
#test_case_started_idprivate method which calls another fake queryType of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses