Open
Conversation
Contributor
|
you are the best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major change in
Pyscriptcore. Please review it very carefully, especiallyast_try,ast_raise, andEvalFunc.call.Originally this was one large change, but I split it into smaller commits to make it easier to review. Each commit is consistent. Everything works and the tests pass.
Main idea:
finallywhere needed to restore contextException logging:
Initially, I planned to keep the old behavior and show only a single frame where the error occurred, but I ended up implementing a full traceback 🙂
EvalExceptionFormatter
tracebackmechanisms are used, with adjustments for user codelinenoandcol_offsetare taken fromast.expr/ast.stmt, which results in more precise error locationsTests:
There are many changes because the new mechanism closely matches native python behavior and is more precise.
Please pay attention to the last commit with exception chaining - it tests pyscript using pyscript itself.