feat(feed): add sentiment popup for feed feedback#5504
Open
Daily-Dave wants to merge 2 commits intomainfrom
Open
feat(feed): add sentiment popup for feed feedback#5504Daily-Dave wants to merge 2 commits intomainfrom
Daily-Dave wants to merge 2 commits intomainfrom
Conversation
Implement sentiment popup modal allowing users to submit feedback about their feed experience through emoji selection (good, neutral, bad). **Features:** - SentimentPopupModal component with animated emoji selection - Randomized emoji order to prevent positional bias - Spring physics animations and glow effects - GraphQL mutation for submitting sentiment - Rate limiting (5 submissions per hour) - Logging integration for analytics **Technical Details:** - Added LazyModal.FeedSentiment enum entry - Created feedSentiment GraphQL types and mutation - Added LogEvent.OpenFeedSentiment and SubmitFeedSentiment events - Added TargetType.FeedSentiment for analytics - CSS animations for modal entrance, emoji selection, and success states - Fisher-Yates shuffle algorithm for emoji randomization Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
**Fixes:** - Add OpenFeedSentiment logging on modal mount for analytics tracking - Remove unused CSS variable --animation-delay (dead code) - Remove unnecessary comments per CLAUDE.md guidelines - Use hardcoded animation delay classes (animation-delay-300/380/460) **Changes:** - Added useEffect to log OpenFeedSentiment event when modal opens - Removed inline style with unused CSS variable - Cleaned up redundant comments - Simplified component structure Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Daily-Dave
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sentiment popup modal to collect user feedback on feed relevance.
Changes
SentimentPopupModalcomponent with thumbs up/down sentiment selection/feedSentimentmutationImplementation decisions
Closes ENG-720
Created by Huginn 🐦⬛
Preview domain
https://eng-720-add-sentiment-popup-to-f.preview.app.daily.dev