Fixed wrong character range in preg pattern in slugify function#192
Open
unti1x wants to merge 1 commit intodanielstjules:masterfrom
unti1x:bugfix/invalid-range
Open
Fixed wrong character range in preg pattern in slugify function#192unti1x wants to merge 1 commit intodanielstjules:masterfrom unti1x:bugfix/invalid-range
unti1x wants to merge 1 commit intodanielstjules:masterfrom
unti1x:bugfix/invalid-range
Conversation
lukasz-schab
approved these changes
Jan 7, 2019
lukasz-schab
left a comment
There was a problem hiding this comment.
I just came in to propose the same amendment.
|
Same. |
|
Unfortunately this is blocking us from updating to php 7.3 |
|
We pushed an official fork of Stringy to Packagist with this fix because it was a pretty big deal for Statamic. Feel free to use it, we'll keep it supported as long as this repo stays a ghost town. https://packagist.org/packages/statamic/stringy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed following warning: