Skip to content

Conversation

@knard38
Copy link
Contributor

@knard38 knard38 commented Jan 27, 2026

Description

This PR introduce some code refactoring of the DDB code, for being able to add some unit and integration tests to the DBB go code:

  • The GO interface DdbApi is introduced to allow the use of GO test stub.
  • Refactor initialisation of the C structure from the Go Code to allow the use of GO test stub.
  • The useless C attributes dc_pool_path and dc_db_path are removed.

It also fixes miscellaneous issues:

  • Remove invalid restrictions on pool file path size.
  • Improper cleanup of the function ddb_run_feature().
  • Add db_path parameter to Pool destroy command.
  • Fix invalid return code with non-interactive mode

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@knard38 knard38 self-assigned this Jan 27, 2026
@knard38 knard38 added the CR Catastrophic Recovery Feature label Jan 27, 2026
@github-actions
Copy link

Ticket title is 'Add unit test to ddb go code'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18304

@daosbuild3
Copy link
Collaborator

@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from cbcad01 to 1a958d2 Compare January 28, 2026 06:01
@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17464/1/execution/node/1358/log

@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from 1a958d2 to 29e0a66 Compare January 28, 2026 06:31
@daosbuild3
Copy link
Collaborator

@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from 29e0a66 to ecd74b5 Compare January 28, 2026 15:05
@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17464/3/execution/node/1314/log

@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18323 branch 2 times, most recently from 08b5a70 to f23c95c Compare January 29, 2026 08:59
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from ecd74b5 to 26c3d1c Compare January 29, 2026 09:24
@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-17464/4/display/redirect

@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17464/4/execution/node/1352/log

@daosbuild3
Copy link
Collaborator

@daosbuild3
Copy link
Collaborator

@daosbuild3
Copy link
Collaborator

Test stage Build on Leap 15.5 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17464/5/execution/node/318/log

@daosbuild3
Copy link
Collaborator

@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18323 branch from f23c95c to c013fe7 Compare January 29, 2026 13:32
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from 26c3d1c to be529b5 Compare January 29, 2026 14:45
@daosbuild3
Copy link
Collaborator

Refactoring DDB code to allow unit testing of the go part code.

Features: recovery
Signed-off-by: Cedric Koch-Hofer <[email protected]>
@knard38 knard38 force-pushed the ckochhof/fix/master/daos-18304 branch from be529b5 to 13e1c60 Compare January 30, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CR Catastrophic Recovery Feature

Development

Successfully merging this pull request may close these issues.

4 participants