DAOS-18478 tests: Escape self_heal value in POOL13#17475
Merged
daltonbohning merged 1 commit intomasterfrom Feb 2, 2026
Merged
DAOS-18478 tests: Escape self_heal value in POOL13#17475daltonbohning merged 1 commit intomasterfrom
daltonbohning merged 1 commit intomasterfrom
Conversation
|
Ticket title is 'daos_test POOL13 doesn't clean up |
github-actions
bot
added
the
priority
Collaborator
|
Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17475/1/execution/node/1207/log |
When calling daos_pool_set_prop for self_heal, we have to escape the ';'s in the value. With this fix POOL16 and POOL17 rebuild tasks will start properly. And, due to #17028, each rebuild task takes 10 s longer now. Hence, we have to increase the test timeout. Test-tag: test_daos_pool Signed-off-by: Li Wei <liwei@hpe.com>
liw
force-pushed
the
liw/daos_test-pool-ii
branch
from
0895404 to
6aadbd5
Compare
kccain
approved these changes
Feb 2, 2026
daltonbohning
added
the
forced-landing
Contributor
|
Sorry, this showed up in my gatekeeping list for some reason and I didn't catch that it was just a review until after I merged it |
Contributor
|
I at least did review and LGTM |
Contributor
Author
|
Thanks, Dalton. I did consider it ready for landing. |
liw
added a commit
that referenced
this pull request
Feb 3, 2026
When calling daos_pool_set_prop for self_heal, we have to escape the ';'s in the value. With this fix POOL16 and POOL17 rebuild tasks will start properly. And, due to #17028, each rebuild task takes 10 s longer now. Hence, we have to increase the test timeout. Signed-off-by: Li Wei <liwei@hpe.com>
daltonbohning
pushed a commit
that referenced
this pull request
Feb 6, 2026
…17217) Changes from #16848: It is impossible to turn off all flags of pool property self_heal, because dmg pool set-prop disallows empty value syntax. This patch adds "none" as a valid value for pool property self_heal, to indicate that all flags are turned off. Changes from #17401: daos_test POOL13 should restore the original value of pool property self_heal, or later tests may be affected. Changes from #17475: When calling daos_pool_set_prop for self_heal, we have to escape the ';'s in the value. With this fix POOL16 and POOL17 rebuild tasks will start properly. And, due to #17028, each rebuild task takes 10 s longer now. Hence, we have to increase the test timeout. Signed-off-by: Li Wei <liwei@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling daos_pool_set_prop for self_heal, we have to escape the ';'s in the value.
With this fix POOL16 and POOL17 rebuild tasks will start properly. And, due to #17028, each rebuild task takes 10 s longer now. Hence, we have to increase the test timeout.
Test-tag: test_daos_pool
Steps for the author:
After all prior steps are complete: