mtls: add -k flag to export and expiry subcommands - #1696
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
These two subcommands are Kubernetes only already but never registered the -k shorthand every other mtls-adjacent command uses, so cobra rejected it as an unknown flag. Register it the same way the sibling commands do. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dapr mtls exportanddapr mtls expirynever registered the-k/--kubernetesflag that every other mtls-adjacent command (dapr mtls,renew-certificate,init,upgrade, etc.) exposes, so cobra rejected it with "unknown shorthand flag". This PR registers the same flag on both subcommands, matching the existing pattern used throughout the rest of the CLI.Issue reference
Please reference the issue this PR will close: #944
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Notes:
go build .and confirmeddapr mtls export -k/dapr mtls expiry -kno longer fail with "unknown shorthand flag".cmd/mtls.go's flag registration, and neither subcommand'sRunfunction readskubernetesMode(they're Kubernetes-only already), so there's no behavior to unit test beyond flag parsing, which was verified manually.