Skip to content

fix: adapt to durabletask-protobuf proto file split#1702

Merged
cicoyle merged 1 commit intodapr:masterfrom
javier-aliaga:fix/durabletask-proto-split
Mar 26, 2026
Merged

fix: adapt to durabletask-protobuf proto file split#1702
cicoyle merged 1 commit intodapr:masterfrom
javier-aliaga:fix/durabletask-proto-split

Conversation

@javier-aliaga
Copy link
Copy Markdown
Contributor

@javier-aliaga javier-aliaga commented Mar 26, 2026

Description

The dapr/durabletask-protobuf#32 PR refactored protos by concept, splitting orchestrator_service.proto into orchestration.proto, history_events.proto, and orchestrator_actions.proto. This broke the build because only the single file was being downloaded.

  • Download all 4 proto files in durabletask-client/pom.xml
  • Replace single-file URL property with base URL in parent pom
  • Update Java type references from OrchestratorService.* to the correct new outer classes: Orchestration, HistoryEvents, OrchestratorActions

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the durabletask client module to build against the refactored dapr/durabletask-protobuf protos after orchestrator_service.proto was split into concept-based proto files.

Changes:

  • Switch durabletask proto configuration from a single-file URL to a base URL in the parent pom.xml.
  • Download all required durabletask proto files (orchestrator_service.proto, orchestration.proto, history_events.proto, orchestrator_actions.proto) in durabletask-client/pom.xml.
  • Update Java references from OrchestratorService.* message types to the new outer classes (Orchestration, HistoryEvents, OrchestratorActions) across runtime code and tests.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pom.xml Replaces durabletask single-proto URL property with a base URL property for multiple proto downloads.
durabletask-client/pom.xml Adds download-maven-plugin executions to fetch all split proto files needed for codegen/compilation.
durabletask-client/src/test/java/io/dapr/durabletask/SubOrchestrationCrossAppTest.java Updates test references to the new generated proto outer classes and message types.
durabletask-client/src/main/java/io/dapr/durabletask/runner/OrchestratorRunner.java Updates OrchestrationVersion reference to the new Orchestration outer class.
durabletask-client/src/main/java/io/dapr/durabletask/runner/ActivityRunner.java Updates TaskFailureDetails and TraceContext references to Orchestration.
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestratorResult.java Updates action type to OrchestratorActions.OrchestratorAction.
durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java Updates history/event/action/router/status types to the new generated outer classes.
durabletask-client/src/main/java/io/dapr/durabletask/OrchestrationRuntimeStatus.java Updates status enum conversions to use Orchestration.OrchestrationStatus.
durabletask-client/src/main/java/io/dapr/durabletask/OrchestrationMetadata.java Switches OrchestrationState type import to Orchestration.OrchestrationState.
durabletask-client/src/main/java/io/dapr/durabletask/FailureDetails.java Switches TaskFailureDetails type import to Orchestration.TaskFailureDetails.
durabletask-client/src/main/java/io/dapr/durabletask/DurableTaskGrpcWorker.java Updates TraceContext reference to Orchestration.TraceContext.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The dapr/durabletask-protobuf#32 PR refactored protos by concept,
splitting orchestrator_service.proto into orchestration.proto,
history_events.proto, and orchestrator_actions.proto. This broke
the build because only the single file was being downloaded.

- Download all 4 proto files in durabletask-client/pom.xml
- Replace single-file URL property with base URL in parent pom
- Update Java type references from OrchestratorService.* to the
  correct new outer classes: Orchestration, HistoryEvents,
  OrchestratorActions

Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga force-pushed the fix/durabletask-proto-split branch from 42e687c to 0d29c47 Compare March 26, 2026 11:44
@javier-aliaga javier-aliaga marked this pull request as ready for review March 26, 2026 12:20
@javier-aliaga javier-aliaga requested review from a team as code owners March 26, 2026 12:20
@cicoyle cicoyle merged commit 8fda1c2 into dapr:master Mar 26, 2026
10 of 12 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.53%. Comparing base (8f304f6) to head (0d29c47).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1702      +/-   ##
============================================
- Coverage     79.54%   79.53%   -0.02%     
- Complexity     2196     2197       +1     
============================================
  Files           238      238              
  Lines          6591     6591              
  Branches        732      732              
============================================
- Hits           5243     5242       -1     
- Misses          990      992       +2     
+ Partials        358      357       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants