fix(build): handle rate limiting causing failures in build#958
Open
fix(build): handle rate limiting causing failures in build#958
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow that validates examples to be more resilient to GitHub API rate limiting when resolving “latest” Dapr runtime/CLI versions, which was causing broken download URLs and failing builds.
Changes:
- Uses authenticated GitHub API requests (via
GITHUB_TOKEN) andjqto reliably resolve the latest Dapr Runtime and Dapr CLI release tags. - Adds explicit checks to fail fast when a release version cannot be resolved.
- Replaces the CLI install script usage with a direct download + extract of the Dapr CLI binary.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
==========================================
+ Coverage 86.63% 88.99% +2.36%
==========================================
Files 84 103 +19
Lines 4473 7340 +2867
==========================================
+ Hits 3875 6532 +2657
- Misses 598 808 +210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Sam <sam@diagrid.io>
Signed-off-by: Samantha Coyle <sam@diagrid.io>
…n-sdk into fix-flakey-build-step-3.14
Signed-off-by: Samantha Coyle <sam@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There have been several PRs such as this one with 3.14 failing the build on the validation of the quickstarts: https://github.com/dapr/python-sdk/actions/runs/23053657978/job/66961073927
This is because curl fetches the latest version and gets rate-limited since this is unathenticated calls, and then DAPR_CLI_VER is an empty string, which yields the broken zip URL of
download//dapr_linux_amd64.tar.gz.This PR makes the curl authenticated which should increase our rate limits and use proper json parsing with jq and more reliable checks for proper installation.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: