Merged
Conversation
darosior
force-pushed
the
2407_release_3.5
branch
2 times, most recently
from
2cdb690 to
5dbb9f0
Compare
Closed
|
We'd like to update our project to coincurves 20 but it also uses python-bip32 which is stuck at coincurves < 19. Is it still planned to merge this PR? |
Owner
Author
|
Yes. I need to get back to it.
-------- Original Message --------
On 9/4/24 11:18 AM, callebtc wrote:
We'd like to update our project to coincurves 20 but it also uses python-bip32 which is stuck at coincurves < 19. Is it still planned to merge this PR?
—
Reply to this email directly, [view it on GitHub](#43 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3F5BUHPALLWM7BJS2GLZU3F5NAVCNFSM6AAAAABLIFWFGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRYGM2DGNBQGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
@github.com>
|
darosior
force-pushed
the
2407_release_3.5
branch
from
5dbb9f0 to
db8257d
Compare
Owner
Author
|
Finally got around to tame the MacOS ci to finalize this. Will merge and publish the release now. |
Owner
Author
|
python-bip32 v4.0 with support for coincurve v20 is now up. |
|
Awesome, thank you! |
Contributor
|
I just opened a PR to allow version 21, which removes all runtime dependencies 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over #40 now that Coincurve appears to be fixed (see ofek/coincurve#133 (comment)). Based on #42.