Open
Conversation
…o_0.53.0 Refactored for new page structure
This changes the filename extraction from TOC URLs to remove any .html suffix and anything before a final slash (final slash optional).
|
@bendman thank you so much for the awesome works. I noticed that Properties tab on the left is not working?
It was already like that before this update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely thanks to work by @vexus2, but I updated the Table of Contents filename extraction to ignore everything before the final slash since some URLs now are absolute and contain subdirectories.
Example of different
hrefattributes handled now:Previously this would return
docsas the filename for the second link because it would assume there was a file extension. This new format doesn't assume the filename extension, but removes it if it exists.