fix: announce tip to new peers when synced#490
Draft
xdustinface wants to merge 4 commits intov0.42-devfrom
Draft
fix: announce tip to new peers when synced#490xdustinface wants to merge 4 commits intov0.42-devfrom
xdustinface wants to merge 4 commits intov0.42-devfrom
Conversation
When synced, `handle_headers_pipeline` always calls `send_pending()` after receiving each new block header, triggering a follow-up `GetHeaders` that always returned empty. This causes lot of unnecessary round-trips and leaves the tip segment in a pending state that rejected the next actual header as "unrequested headers". Use `tip_was_complete` to distinguish unsolicited headers from active catch-up responses. Only skip `send_pending()` and mark the tip complete for the unsolicited case, so multi-batch catch-up still works correctly.
Deduplicate `GetHeaders` → `GetHeaders2` upgrade logic from `send_to_single_peer` and `send_distributed` into a shared `send_message_to_peer` method.
Add `SendMessageToPeer` variant to `NetworkRequest` and `request_block_headers_from_peer` to `RequestSender` so sync managers can request block headers from specific peers.
When already synced, send a `GetHeaders` with our tip locator to each newly connected peer. Without this, Dash Core never learns our best-known header and falls back to inv announcements instead of pushing unsolicited header messages.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
merge-conflict
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When already synced, send a
GetHeaderswith our tip locator to eachnewly connected peer. Without this, Dash Core never learns our best-known
header and falls back to inv announcements instead of pushing unsolicited
header messages.
Based on:
GetHeadersafter post-sync header processing #486request_block_headers_from_peertoRequestSender#489