chore(key-wallet): drop unused UtxoSet struct#491
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoved the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@key-wallet/src/lib.rs`:
- Line 72: The public API removed UtxoSet but the README example still imports
and uses it; update the example to stop referencing UtxoSet and show usage with
Utxo only. Edit the README example that currently does `use ...::UtxoSet` and
replace the snippet with code that constructs/iterates/manipulates Utxo
instances (e.g., creating Utxo values, collecting them into a Vec or other local
container, and using the existing Utxo APIs) so documentation compiles against
the current public export `Utxo`.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
key-wallet-manager/src/lib.rskey-wallet/src/lib.rskey-wallet/src/utxo.rs
💤 Files with no reviewable changes (1)
- key-wallet/src/utxo.rs
thepastaclaw
left a comment
There was a problem hiding this comment.
Looks good — removing unused abstractions keeps the API surface clean. 👍
One thing to address: as CodeRabbit flagged, key-wallet-manager/README.md still references UtxoSet in the UTXO Management example (lines 154-167). That example will need updating to only use Utxo directly, or the section can be simplified/removed if there's no meaningful standalone Utxo usage example to show.
ef1333c to
6e1a884
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.42-dev #491 +/- ##
============================================
Coverage ? 64.48%
============================================
Files ? 330
Lines ? 65157
Branches ? 0
============================================
Hits ? 42018
Misses ? 23139
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We are not using this struct internally and I don't see any value on having it for library users
Summary by CodeRabbit
Breaking Changes
Documentation