Skip to content

feat(key-wallet): add BlockchainIdentities account type #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lklimek wants to merge 6 commits into
base: v0.42-dev
Choose a base branch
from
+883 −15

Merge remote-tracking branch 'origin/v0.42-dev' into feat/blockchain-…

6e95bf2
Select commit
Loading
Failed to load commit list.
Open

feat(key-wallet): add BlockchainIdentities account type #554

Merge remote-tracking branch 'origin/v0.42-dev' into feat/blockchain-…
6e95bf2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 21, 2026 in 0s

66.26% (-0.07%) compared to 5edf719

View this Pull Request on Codecov

66.26% (-0.07%) compared to 5edf719

Details

Codecov Report

❌ Patch coverage is 46.55172% with 248 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.26%. Comparing base (5edf719) to head (6e95bf2).
⚠️ Report is 2 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
key-wallet-ffi/src/transaction_checking.rs 0.00% 56 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 0.00% 36 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 45.31% 35 Missing ⚠️
...wallet/src/managed_account/managed_account_type.rs 14.28% 30 Missing ⚠️
.../src/managed_account/managed_account_collection.rs 76.08% 22 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 0.00% 16 Missing ⚠️
key-wallet/src/managed_account/mod.rs 0.00% 16 Missing ⚠️
key-wallet/src/account/account_collection.rs 80.00% 12 Missing ⚠️
key-wallet-ffi/src/types.rs 0.00% 8 Missing ⚠️
...src/transaction_checking/transaction_router/mod.rs 33.33% 8 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #554      +/-   ##
=============================================
- Coverage      66.33%   66.26%   -0.07%     
=============================================
  Files            311      311              
  Lines          64976    65440     +464     
=============================================
+ Hits           43103    43367     +264     
- Misses         21873    22073     +200
Files with missing lines Coverage Δ
key-wallet/src/account/mod.rs 66.76% <100.00%> (+3.97%) ⬆️
key-wallet/src/wallet/helper.rs 43.00% <73.33%> (+0.95%) ⬆️
key-wallet/src/account/account_type.rs 55.72% <72.22%> (+5.99%) ⬆️
key-wallet-ffi/src/types.rs 57.21% <0.00%> (-1.21%) ⬇️
...src/transaction_checking/transaction_router/mod.rs 83.96% <33.33%> (-5.11%) ⬇️
key-wallet/src/account/account_collection.rs 61.75% <80.00%> (+2.77%) ⬆️
key-wallet-ffi/src/managed_account.rs 45.95% <0.00%> (+2.04%) ⬆️
key-wallet/src/managed_account/mod.rs 48.22% <0.00%> (-1.42%) ⬇️
.../src/managed_account/managed_account_collection.rs 58.07% <76.08%> (+2.40%) ⬆️
...wallet/src/managed_account/managed_account_type.rs 21.78% <14.28%> (-0.72%) ⬇️
... and 3 more

... and 3 files with indirect coverage changes

View more details on Codecov