Skip to content

fix: include BlockchainIdentities accounts in find_address_account() lookup#555

Merged
lklimek merged 2 commits intofeat/blockchain-identities-account-typefrom
copilot/sub-pr-554
Mar 16, 2026
Merged

fix: include BlockchainIdentities accounts in find_address_account() lookup#555
lklimek merged 2 commits intofeat/blockchain-identities-account-typefrom
copilot/sub-pr-554

Conversation

Copy link

Copilot AI commented Mar 16, 2026

ManagedCoreAccount::find_address_account() was blind to all four blockchain_identities_* account variants, causing address-to-account lookups to return None for any DIP-9 identity paths.

Changes

  • account_checker.rs: Added checks for blockchain_identities_ecdsa, blockchain_identities_ecdsa_hash160, blockchain_identities_bls, and blockchain_identities_bls_hash160 in find_address_account(), consistent with the existing Option<Account> singleton pattern used for identity_registration etc.
if let Some(account) = &collection.blockchain_identities_ecdsa {
    if account.contains_address(address) {
        return Some((AccountTypeToCheck::BlockchainIdentitiesECDSA, None));
    }
}
// ... repeated for _ecdsa_hash160, _bls, _bls_hash160

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

Co-authored-by: lklimek <842586+lklimek@users.noreply.github.com>
Copy link
Author

Copilot AI commented Mar 16, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/dashpay/rs-x11-hash/commits/0.1.9
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.92.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.92.0-x86_64-REDACTED-linux-gnu/bin/cargo build -p key-wallet --all-features ACCEPT (http block)
  • https://api.github.com/repos/dashpay/vsss-rs/commits/main
    • Triggering command: /home/REDACTED/.rustup/toolchains/1.92.0-x86_64-REDACTED-linux-gnu/bin/cargo /home/REDACTED/.rustup/toolchains/1.92.0-x86_64-REDACTED-linux-gnu/bin/cargo build -p key-wallet --all-features ACCEPT (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] [WIP] Address feedback on BlockchainIdentities account type implementation fix: include BlockchainIdentities accounts in find_address_account() lookup Mar 16, 2026
Copilot AI requested a review from lklimek March 16, 2026 17:31
@lklimek lklimek marked this pull request as ready for review March 16, 2026 17:38
@lklimek lklimek merged commit b4df963 into feat/blockchain-identities-account-type Mar 16, 2026
@lklimek lklimek deleted the copilot/sub-pr-554 branch March 16, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants