feat(dash-spv): add notify_wallet_addresses_changed() API

[lklimek]

Summary

Add a public API for triggering mempool bloom filter rebuild when wallet addresses change externally.

• New SyncEvent::WalletAddressesChanged variant
• New DashSpvClient::notify_wallet_addresses_changed() public method
• MempoolManager handles the event by rebuilding the bloom filter on all active peers

Problem

The MempoolManager builds its bloom filter when peers are first activated (after sync completes). When new wallets are added or addresses registered after initial connection, the bloom filter becomes stale — it doesn't include the new addresses. This means incoming transactions and InstantSend locks for those addresses are not relayed by peers.

Concrete failure in dash-evo-tool E2E tests

The send_funds test does a two-hop payment chain:

Framework wallet  →(5M duffs)→  Test wallet A  →(2M duffs)→  Test wallet B
     hop 1                           hop 2

Hop 1 works (~25s): Framework wallet was loaded before SPV started, so its addresses are in the initial bloom filter.

Hop 2 fails (120s timeout): Test wallet B is created after SPV started. Its addresses are added to WalletManager but the mempool bloom filter is never rebuilt. The IS lock message for hop 2 passes through the stale bloom filter, doesn't match, and the peer never relays it.

Result: Timed out waiting for spendable balance >= 5000000 duffs (confirmed: 0, total: 5000000) — funds visible but never become spendable because the IS lock is never received.

Affected code paths in dash-evo-tool

1. New wallet creation — queue_spv_wallet_load() adds a wallet to WalletManager after SPV is running
2. DashPay contact addresses — register_dashpay_addresses_for_identity() adds contact payment addresses to the wallet's watched_addresses map
3. BlockchainIdentities addresses — Identity System addresses (m/9'/coinType'/5'/subfeature'/index) bootstrapped by DET directly

All three paths add addresses to the wallet after the bloom filter was built. Without a rebuild trigger, these addresses aren't monitored until the next block confirmation with gap limit changes or SPV reconnect.

What we need from rust-dashcore

Requirement: A public API on DashSpvClient that triggers a mempool bloom filter rebuild using the wallet's current monitored_addresses() and watched_outpoints().

This PR implements one possible approach (SyncEvent::WalletAddressesChanged dispatched through the coordinator's broadcast channel). Alternative approaches that satisfy the same requirement are welcome — the key contract is:

1. Consumer calls a method after modifying the wallet's address set
2. The mempool bloom filter is rebuilt on all active peers with the updated addresses
3. No peer disconnection or other side effects

Test plan

• cargo check --workspace passes
• cargo clippy --workspace --all-targets -- -D warnings passes
• cargo test -p dash-spv --lib — 358 tests pass
• Integration test with dash-evo-tool E2E send_funds (in progress — verifying IS lock detection for dynamically created wallets)

_{🤖 Co-authored by Claudius the Magnificent AI Agent}

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7aaca7f8-0254-4b8c-bb03-bfd5525c9994

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/mempool-filter-rebuild

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 91.60457% with 169 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.29%. Comparing base (1de2479) to head (8e6e267).
⚠️ Report is 8 commits behind head on feat/mempool-support.

Files with missing lines	Patch %	Lines
dash-spv/src/sync/mempool/sync_manager.rs	87.21%	51 Missing ⚠️
dash-spv/src/sync/mempool/manager.rs	97.55%	25 Missing ⚠️
dash-spv/src/sync/progress.rs	36.11%	23 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs	0.00%	17 Missing ⚠️
dash-spv-ffi/src/callbacks.rs	29.16%	17 Missing ⚠️
key-wallet-manager/src/wallet_manager/mod.rs	81.08%	7 Missing ⚠️
dash-spv/src/sync/sync_coordinator.rs	45.45%	6 Missing ⚠️
key-wallet-manager/src/events.rs	0.00%	6 Missing ⚠️
dash-spv/src/client/events.rs	0.00%	4 Missing ⚠️
...wallet-manager/src/wallet_manager/process_block.rs	96.66%	4 Missing ⚠️
... and 7 more

Additional details and impacted files

@@                   Coverage Diff                    @@
##           feat/mempool-support     #567      +/-   ##
========================================================
+ Coverage                 66.37%   67.29%   +0.92%     
========================================================
  Files                       311      316       +5     
  Lines                     64979    66972    +1993     
========================================================
+ Hits                      43130    45070    +1940     
- Misses                    21849    21902      +53     

Flag	Coverage Δ
core	75.13% <ø> (ø)
ffi	37.64% <47.69%> (+0.12%)	⬆️
rpc	28.28% <ø> (ø)
spv	83.21% <93.22%> (+2.00%)	⬆️
wallet	66.46% <92.03%> (+0.52%)	⬆️

Files with missing lines	Coverage Δ
dash-spv-ffi/src/types.rs	92.85% <100.00%> (+0.70%)	⬆️
dash-spv/src/client/lifecycle.rs	64.81% <100.00%> (+1.35%)	⬆️
dash-spv/src/network/mod.rs	72.72% <100.00%> (+23.36%)	⬆️
dash-spv/src/sync/blocks/manager.rs	94.82% <100.00%> (+0.09%)	⬆️
dash-spv/src/sync/identifier.rs	100.00% <100.00%> (ø)
dash-spv/src/sync/mempool/progress.rs	100.00% <100.00%> (ø)
...wallet/src/transaction_checking/account_checker.rs	64.01% <100.00%> (+0.05%)	⬆️
...-wallet/src/transaction_checking/wallet_checker.rs	95.42% <ø> (+0.31%)	⬆️
...allet/managed_wallet_info/wallet_info_interface.rs	79.48% <100.00%> (+10.18%)	⬆️
dash-spv/src/network/manager.rs	63.19% <0.00%> (+1.69%)	⬆️
... and 16 more

... and 8 files with indirect coverage changes

[github-actions]

This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them.