Skip to content

chore: remove orphaned key-wallet-manager directory#568

Merged
xdustinface merged 1 commit intov0.42-devfrom
chore/cleanup-key-wallet-manager-leftovers
Mar 20, 2026
Merged

chore: remove orphaned key-wallet-manager directory#568
xdustinface merged 1 commit intov0.42-devfrom
chore/cleanup-key-wallet-manager-leftovers

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Mar 20, 2026

The merge into key-wallet (#503) left few things behind.

Summary by CodeRabbit

  • Chores
    • Removed internal test utilities and package configuration files.

The merge into `key-wallet` (#503) left few things behind.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 29f6274b-c067-4918-990a-459fefc0212e

📥 Commits

Reviewing files that changed from the base of the PR and between 5edf719 and 4cd9587.

📒 Files selected for processing (2)
  • key-wallet-manager/Cargo.toml
  • key-wallet-manager/src/test_utils/wallet.rs
💤 Files with no reviewable changes (2)
  • key-wallet-manager/Cargo.toml
  • key-wallet-manager/src/test_utils/wallet.rs

📝 Walkthrough

Walkthrough

The key-wallet-manager crate has been entirely removed, including its Cargo manifest and test utility implementations for mock wallet interfaces.

Changes

Cohort / File(s) Summary
Package Manifest
key-wallet-manager/Cargo.toml
Deleted entire crate manifest containing package metadata, feature definitions, and dependency declarations.
Test Utilities
key-wallet-manager/src/test_utils/wallet.rs
Removed mock wallet implementations (MockWallet and NonMatchingMockWallet) that provided test fixtures for WalletInterface.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A burrow of code, cleaned and neat,
MockWallets and manifests deleted, complete,
No more test doubles, no more trait,
The key-wallet manager sealed its fate! 🗝️✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: remove orphaned key-wallet-manager directory' directly and specifically describes the main change in the changeset: deletion of the entire key-wallet-manager directory including its Cargo.toml and test utilities modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/cleanup-key-wallet-manager-leftovers
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the ready-for-review CodeRabbit has approved this PR label Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.31%. Comparing base (5edf719) to head (4cd9587).
⚠️ Report is 1 commits behind head on v0.42-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #568      +/-   ##
=============================================
- Coverage      66.33%   66.31%   -0.03%     
=============================================
  Files            311      311              
  Lines          64976    64976              
=============================================
- Hits           43103    43090      -13     
- Misses         21873    21886      +13     
Flag Coverage Δ
core 75.13% <ø> (ø)
ffi 36.80% <ø> (ø)
rpc 28.28% <ø> (ø)
spv 81.01% <ø> (-0.11%) ⬇️
wallet 66.27% <ø> (ø)
see 4 files with indirect coverage changes

@xdustinface xdustinface merged commit be0f1fa into v0.42-dev Mar 20, 2026
36 checks passed
@xdustinface xdustinface deleted the chore/cleanup-key-wallet-manager-leftovers branch March 20, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review CodeRabbit has approved this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant