Skip graceful worker retirement during cluster teardown - #9368
Open
abhisek343 wants to merge 2 commits into
Open
abhisek343 wants to merge 2 commits into
abhisek343 wants to merge 2 commits into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 40 files ± 0 40 suites ±0 14h 34m 40s ⏱️ + 4m 31s For more details on these failures, see this check. Results for commit c60b590. ± Comparison against base commit dc182bd. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9300
Full "SpecCluster" teardown currently calls "scheduler_comm.retire_workers()" before closing workers, even after the cluster has entered "Status.closing". This can trigger unnecessary data replication/drop work immediately before all workers are removed.
This change skips scheduler retirement only during full cluster teardown. Normal scale-down continues to retire workers gracefully.
A regression test verifies that closing the cluster:
does not call "retire_workers()"
still closes the worker
removes the worker from cluster state
Tests added
Tests passed
Passes "pixi run lint"