Upgrade jackson version#249
Draft
sidhdirenge wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Jackson dependency version to 2.13.4.2 in pom.xml. The review feedback points out that although the pull request title indicates an upgrade for both Jackson and Netty, the Netty version upgrade is missing from the changes.
| <logback.version>1.0.9</logback.version> | ||
| <slf4j.version>1.7.25</slf4j.version> | ||
| <jackson.version>2.10.5.1</jackson.version> | ||
| <jackson.version>2.13.4.2</jackson.version> |
There was a problem hiding this comment.
The pull request title indicates an upgrade for both Jackson and Netty versions ("Upgrade jackson and netty version"), but the changes only update jackson.version to 2.13.4.2. The Netty version upgrade appears to be missing from this pull request. Please include the Netty version upgrade or update the pull request title/description accordingly.
sidhdirenge
changed the title
sidhdirenge
force-pushed
the
jetski/fix-vulns-jackson-netty
branch
from
4194b08 to
3a71df0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.