feat(config): Add support for overriding framework config#28
Open
liamperritt wants to merge 5 commits intomainfrom
Open
feat(config): Add support for overriding framework config#28liamperritt wants to merge 5 commits intomainfrom
liamperritt wants to merge 5 commits intomainfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow forked repos to override framework config without being impacted by upstream OSS config changes.
If a forked repo makes changes to the
src/configfolder to customise the framework for their purposes, upstream OSS changes to the files in thesrc/configfolder risk impacting downstream forked repos.This change adds an empty
src/config_overridefolder where forked repos can add and change framework config without any risk of upstream OSS config changes impacting their customised config.The proposal is that if there are any non-hidden files within
src/config_override, then this folder is leveraged by the framework for configuration. Otherwise, the framework will fall back tosrc/config.This has been manually tested against the sample job "Run 1 - Load and Schema Initialization":