dresources: remove permissions/grants special-casing from plan and migrate - #6302
Merged
Conversation
…grate Two optional adapter hooks, Configure(resourceType) and PrepareInputConfig(inputConfig, resourceKey), replace the suffix/prefix dispatch that makePlan and BuildStateFromTF each carried. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 153a6a6
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 6 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac
andrewnester
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makePlanandBuildStateFromTFeach dispatched onstrings.HasSuffix(node, ".permissions")/".grants", plus aresources.secret_scopes.prefix check that repeated a dispatchSupportedResourcesalready does. Two optional adapter hooks replace both branches with a singlePrepareInputConfigcall:Configure(resourceType)runs once per registered type at adapter construction. Permissions and grants resolve their object type prefix and securable type there instead of re-parsing the node on every plan, so a type registered inall.gowithout a matching prefix entry now fails inInitAllinstead of at plan time.PrepareInputConfig(inputConfig, resourceKey)returns the value passed toPrepareStatetogether with theobject_id/full_namereference, replacing the three exportedPrepare*InputConfigfunctions.Tests
Unit tests pin the
object_idreference format (the defaultidfield and themodels->model_idoverride), which was only covered end-to-end before.