Add group assumption for OAuth authentication - #308
Open
mihaimitrea-db wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds group role assumption to OAuth M2M and OIDC token exchange requests. This is the second PR in the stack and is stacked on #307.
Why
#307 makes group configuration available to authentication and prevents unsupported PAT or CLI strategies from silently ignoring it. OAuth providers still need to send that group to the token endpoint; otherwise the issued token does not assume the requested role.
This PR completes the flow by sending
assume_grouponly during OAuth token acquisition. It does not add group headers to ordinary API calls or change generated client options.What changed
Interface changes
groupIdtoDatabricksOidcTokenProviderConfig.M2mCredentialsOptions.groupId, introduced in Add group configuration and auth validation #307, now affects OAuth M2M token grants.Behavioral changes
assume_groupfor non-empty group IDs.assume_groupfor non-empty group IDs.Internal changes
How is this tested?
Passed the full repository checks:
npm run formatnpm run lintnpm run typechecknpm testnpm run test:browsernpm run build