[Rust] Reset ack timeout on progress - #792
Open
zlata-stefanovic-db wants to merge 1 commit into
Open
Conversation
Duplicate or stale acks no longer postpone recovery. Signed-off-by: Zlata Stefanovic <zlata.stefanovic@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #639.
The gRPC receiver used a per-read timeout around every inbound frame. Any message reset the lack-of-ack clock, including a stale or duplicate
durability_ack_up_to_offsetthat did not advance durability. A server repeating the same ack could postpone recovery indefinitely while later offsets stayed unacknowledged.This PR keeps one deadline and moves it only when the ack watermark advances. Duplicate/stale acks and other frames no longer extend the budget.
How is this tested?
cargo test -p databricks-zerobus-ingest-sdkcargo test -p tests --test rust_teststest_duplicate_acks_do_not_reset_server_ack_timeoutdribbles duplicate acks every 50ms and asserts the stream still fails withServer ack timeoutwithin one timeout window.