Enable multi-entity and set default Dataflow template to 1.0.1#137
Closed
clincoln8 wants to merge 2 commits into
Closed
Enable multi-entity and set default Dataflow template to 1.0.1#137clincoln8 wants to merge 2 commits into
clincoln8 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ingestion workflow module by adding the enableMultiEntity: 'true' parameter and updating the default Dataflow template path to version 1.0.1. The reviewer suggests exposing enableMultiEntity as a configurable variable instead of hardcoding it to maintain flexibility and backward compatibility with older template versions.
… 1.0.1 - Added enableMultiEntity: 'true' to the Dataflow launch parameters in the Cloud Workflow definition. - Updated the default Dataflow template version to ingestion-1.0.1.json in the workflow module variables. - Removed isBaseDc: 'false' from the workflow launch parameters to ensure compatibility with the ingestion-1.0.1.json template (which does not support this parameter). TAG=agy CONV=22ae774d-bd33-45c6-b311-3f67e552a618
clincoln8
force-pushed
the
enable-multi-entity
branch
from
34ce0f7 to
ce2dee8
Compare
clincoln8
commented
Jun 22, 2026
Contributor
Author
|
no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
enableMultiEntity: 'true'to the Dataflow launch parameters in the Cloud Workflow definition. This enables support for multi-entity schemas during ingestion.ingestion-1.0.1.jsonin the workflow module variables.