feat: add spanner based aggregation framework #531
Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Documentation | 8 minor |
| Security | 2 medium |
🟢 Metrics 90 complexity · 2 duplication
Metric Results Complexity 90 Duplication 2
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request introduces a new data aggregation framework in the ingestion helper, adding utility classes for sources (Spanner SQL and local JSONL), sinks (Spanner table and local JSONL), and an AggregationRunner to execute aggregation specifications. It also integrates a new run_aggregation_spec action into the main Flask application along with comprehensive unit tests. The feedback highlights opportunities to improve robustness, specifically by safely handling potentially None fields in the Spanner source, using .get() to prevent KeyErrors during sink writes, and using getattr to safely retrieve the batch size from sinks to avoid AttributeErrors.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.