Emit a warning if includeInputSubdirs is unintentionally unset#573
Emit a warning if includeInputSubdirs is unintentionally unset#573kmoscoe wants to merge 6 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request adds a warning log in simple/stats/runner.py when an input store is a directory but include_input_subdirs is disabled. The reviewer noted that this implementation will trigger false-positive warnings for standard flat directory imports that do not contain subdirectories, and suggested checking for the actual presence of subdirectories before logging the warning.
gmechali
left a comment
There was a problem hiding this comment.
Hey Kara, I dont think this is worth doing tbh, no one will read through those logs...We gotta handle it better right off the bat.
I guess it doesnt hurt either.
So would it be better to do the Gemini suggestion, and automatically the option to true in this context? I just thought that if (in the rare case) the error was not the missing option but the directories, they could intentionally correct it. But it seems like an unlikely case. |
It's easy to forget this, and if you do, you'll likely end up with some impossible-to-debug errors because of references to missing objects.
I think the Java test failures are bogus; just flakiness.