Skip to content

Emit a warning if includeInputSubdirs is unintentionally unset#573

Open
kmoscoe wants to merge 6 commits into
datacommonsorg:masterfrom
kmoscoe:input
Open

Emit a warning if includeInputSubdirs is unintentionally unset#573
kmoscoe wants to merge 6 commits into
datacommonsorg:masterfrom
kmoscoe:input

Conversation

@kmoscoe

@kmoscoe kmoscoe commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

It's easy to forget this, and if you do, you'll likely end up with some impossible-to-debug errors because of references to missing objects.

I think the Java test failures are bogus; just flakiness.

@kmoscoe kmoscoe requested review from clincoln8, gmechali and hqpho and removed request for hqpho June 22, 2026 23:11
@codacy-production

codacy-production Bot commented Jun 22, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a warning log in simple/stats/runner.py when an input store is a directory but include_input_subdirs is disabled. The reviewer noted that this implementation will trigger false-positive warnings for standard flat directory imports that do not contain subdirectories, and suggested checking for the actual presence of subdirectories before logging the warning.

Comment thread simple/stats/runner.py
@kmoscoe kmoscoe requested review from clincoln8 and gmechali and removed request for clincoln8 and gmechali June 22, 2026 23:32

@gmechali gmechali left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Kara, I dont think this is worth doing tbh, no one will read through those logs...We gotta handle it better right off the bat.
I guess it doesnt hurt either.

@kmoscoe

kmoscoe commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Hey Kara, I dont think this is worth doing tbh, no one will read through those logs...We gotta handle it better right off the bat. I guess it doesnt hurt either.

So would it be better to do the Gemini suggestion, and automatically the option to true in this context? I just thought that if (in the rare case) the error was not the missing option but the directories, they could intentionally correct it. But it seems like an unlikely case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants