Skip to content

[v0/v1 migration] Remove use_v2_api feature flag#6404

Open
nick-nlb wants to merge 5 commits into
datacommonsorg:masterfrom
nick-nlb:flag-removal-use-v2-api
Open

[v0/v1 migration] Remove use_v2_api feature flag#6404
nick-nlb wants to merge 5 commits into
datacommonsorg:masterfrom
nick-nlb:flag-removal-use-v2-api

Conversation

@nick-nlb

Copy link
Copy Markdown
Contributor

Related PRs

6355
6396

Description

Remove use_v2_api feature flag from all environment configurations.

This is a follow-up to 6355 and 6396 (linked above) that removed all usage of those flags from the codebase.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the migration to the V2 API by removing the 'use_v2_api' feature flag across all server environment configurations. This change follows previous efforts to clean up the codebase by eliminating obsolete flag references.

Highlights

  • Feature Flag Removal: Removed the 'use_v2_api' feature flag from all environment configuration files, completing the migration to the V2 API.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the obsolete use_v2_api feature flag from all environment configuration files, including autopush, custom, dev, local, production, and staging. I have no feedback to provide.

@nick-nlb nick-nlb requested review from gmechali and juliawu June 23, 2026 00:46
@gmechali

Copy link
Copy Markdown
Contributor

Hey Nick! The rule is never submit a change that includes production.json AND another file. Can you remove the change to production.json, submitt his PR with all the other files, then put up a separate PR just for production.json?

@nick-nlb

Copy link
Copy Markdown
Contributor Author

Hey Nick! The rule is never submit a change that includes production.json AND another file. Can you remove the change to production.json, submitt his PR with all the other files, then put up a separate PR just for production.json?

Updated! Thank you for the sugggestion.

In this case the separation has an additional benefit that we can do this merge now (we need to wait until production actually has 6355 before merging a change the prod flag).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants