Skip to content

Integration test golden updates#6405

Merged
nick-nlb merged 1 commit into
datacommonsorg:masterfrom
nick-nlb:integration-test-golden-updates
Jun 23, 2026
Merged

Integration test golden updates#6405
nick-nlb merged 1 commit into
datacommonsorg:masterfrom
nick-nlb:integration-test-golden-updates

Conversation

@nick-nlb

Copy link
Copy Markdown
Contributor

Related PR

Mixer: 1952

Description

Update goldens for integration tests in response to a change to how facet ids are determined (see related PR).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the golden files used for integration testing. These changes are required due to modifications in how facet IDs are determined, as implemented in the related Mixer PR #1952. The updates ensure that the integration tests correctly validate the current backend behavior.

Highlights

  • Golden File Updates: Updated integration test golden files to align with recent changes in facet ID determination logic.
  • Data Consistency: Synchronized test data configurations and debug information to match the updated backend facet ID generation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates integration test data across several test suites. Specifically, it rounds cosine scores in debug_info.json files to four decimal places and updates statistical variable keys and facet IDs in chart_config.json files. There are no review comments to evaluate, and I have no feedback to provide.

@nick-nlb nick-nlb requested a review from juliawu June 23, 2026 00:02
@nick-nlb nick-nlb marked this pull request as ready for review June 23, 2026 00:02

@juliawu juliawu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the goldens!

@nick-nlb nick-nlb merged commit 1436693 into datacommonsorg:master Jun 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants