Integration test golden updates#6405
Conversation
…acet ids are determined.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the golden files used for integration testing. These changes are required due to modifications in how facet IDs are determined, as implemented in the related Mixer PR #1952. The updates ensure that the integration tests correctly validate the current backend behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates integration test data across several test suites. Specifically, it rounds cosine scores in debug_info.json files to four decimal places and updates statistical variable keys and facet IDs in chart_config.json files. There are no review comments to evaluate, and I have no feedback to provide.
juliawu
left a comment
There was a problem hiding this comment.
Thanks for updating the goldens!
Related PR
Mixer: 1952
Description
Update goldens for integration tests in response to a change to how facet ids are determined (see related PR).