Header z-index fix#6407
Conversation
…l on top of loading overlays (and remain clickable).
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a UI layering issue where loading spinners in visualization tools were obscuring the website header and its dropdown menus. By elevating the header's z-index, the changes ensure that navigation remains accessible during data loading states without interfering with modal display logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the z-index values to 1000 in both core.scss and explore.scss. The reviewer suggests avoiding hardcoded magic numbers by defining a centralized z-index variable in a shared variables file to improve maintainability and prevent layering conflicts.
juliawu
left a comment
There was a problem hiding this comment.
Thank you for the fix!
[Suggestion] It might be nice to add a comment here that the z-index needs to be above the loading spinner screens but below the modals
Issue
b/525123954
Description
This PR fixes a z-index layering issue where page-level loading spinner screens render on top of the main website header and its dropdown menu.
When a visualization tool (Map, Timeline, Scatter, Download, or StatVar Explorer) enters a loading state, the spinner covers the header dropdown menu, making its contents unclickable.
To fix this, we increased the z-index of the fixed header components to
1000, positioning them above the loading spinner screens (z-index: 100) while keeping them below modals and backdrop layers:Notes
Setting the container z-index to
1000matches the z-index level of the header drawer and desktop rich menus. They will renderabove content/spinners, but will still be correctly covered by modal backdrops when modals are open.Testing
http://localhost:8080/tools/map.