Download tool#6411
Draft
pablonoel wants to merge 6 commits into
Draft
Conversation
- Separate the UI Logic - Add page (app) provider with theme - Move state elements into contex.tsx ( as per maps / scatter tools use ) - Remove data range, defaulting to DATE_ALL, updating the validation/url params. - Update facet fetching
- Add pill examples - Remove info_places references an info - Refactor stat_var_chooser access - Add download to shared vis tool components - Add redirects to allow pill link construction - Refactor dowload flash template
- Removes preview button, content reloads when a varStat is selected - Refactor messages and filters logics - Fix url based loader for pills - Reset content when options are emptied
Contributor
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
Contributor
Author
|
@nick-nlb ready for review, let me know if you need more context. |
nick-nlb
reviewed
Jun 25, 2026
nick-nlb
left a comment
nick-nlb
left a comment
Contributor
There was a problem hiding this comment.
Thank you Pablo for all of this!
There are some inline comments, but I'll put a couple of behavioral notes here.
Mismatch of responsive breakpoints.
- View in a wide desktop view
- Select a location (say “United States”)
- Select a breakdown (say “State”)
- You will see “Pick a statistical variable in the left pane” as well as the statistical variable explorer on the left.
- Slowly shrink the viewport
- At a certain point, we flip into mobile/tablet, where the lefthand explorer disappears.
- At this point, the message correctly switches to “Pick a statistical variable using the “select variable” button above.”
- However, the button does not appear.
- Shrink the viewport further, and the button will appear.
Facet Selector State state correspond with selected stat vars [I've suggested a fix in the comments]
- Select “United States”
- Select “State”
- Select Health: Medical Condition: Diabetes: Percentage…”
- You will see two facets (these are correct).
- Now select Total Population
- We expect 15 facets now be available (but we only see the two).
- Refresh the page - you will see fifteen.
Remove preview and validation state management from the download context since they are no longer used. This includes removing PreviewWrapper and ValidationWrapper interfaces, and their associated state from useInitialContext(). Also update loadStateFromURL to accept only the setOptions function instead of the entire context object, and destructure facet methods directly for cleaner code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address the Download Tool refactor, it includes fixing the Facet selector and streamline the interface.
Things to consider: