fix: Keep session on quota 403 and gate tunnel create - #171
Merged
Conversation
Quota admission returns 403 Forbidden, which we treated as auth failure and logged the user out. Only treat 401 as auth now, surface quota limits in the UI, and skip the macOS titlebar offset on Windows and Linux overlays.
mattdjenkinson
marked this pull request as ready for review
July 23, 2026 16:08
kevwilliams
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creating a tunnel when a project was at HTTPProxy quota returned a 403 from Milo admission. We treated every 403 as an auth failure, cleared the session, and sent people back to login with no useful error. That matches app#170.
This keeps the session on non-auth 403s, shows when the project is out of tunnel quota, and links to the portal quotas page so people can free capacity or get help from there.
Key behaviors:
Also stops promoting
warn!logs to Sentry events so expected operational noise (including quota) does not open issues.Fixes #170