Conversation
effectiveUseNetNS previously forced netns on when all MCP servers declared AllowedHosts, even if the user set use_net_ns: false. This caused hard launch failures on systems without unprivileged user namespaces. Now configured=false is always respected. AllowedHosts only preserves netns when the user already opted in (configured=true). Refactored sandbox helpers into run_helpers.go with comprehensive tests (12 effectiveUseNetNS cases covering the bug fix). Closes #680 Assisted-by: SODA Assisted-by: Claude Opus 4.6
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectiveUseNetNSnow respectsconfigured=false— never silently overrides the user's opt-out of network namespace isolationallowed_hostson all MCP servers would force netns on even when explicitly disabled, causing hard launch failures on systems without unprivileged user namespacesChanges
config_build.gointorun_helpers.gowith improved documentationeffectiveUseNetNScovering the bug fix (including the 2 cases that were previously wrong)AllowedHostsonMCPServerConfigsimplified to[]stringCloses #680
Assisted-by: SODA