Skip to content

fix(client): coerce ws scheme on forwarded upgrade target (fixes #1) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlgimenes merged 1 commit into from
May 22, 2026
Merged

fix(client): coerce ws scheme on forwarded upgrade target (fixes #1) #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion handlers.client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,12 @@ async function handleWebSocket(
message: RequestStartMessage,
state: ClientState,
) {
const ws = new WebSocket(new URL(message.url, state.localAddr));
const target = new URL(message.url, state.localAddr);
// Coerce http(s): -> ws(s): so spec-strict runtimes (e.g. Bun) accept it.
// Node's undici silently rewrites the scheme, but Bun keeps `http:` and
// the handshake fails immediately, breaking HMR (Vite/Next) through the tunnel.
target.protocol = target.protocol === "https:" ? "wss:" : "ws:";
const ws = new WebSocket(target);
try {
const wsCh = await makeWebSocket<ArrayBuffer, ArrayBuffer, ArrayBuffer>(
ws,
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading