feat(ui): DH-19818: add nested dashboard support by mofojed · Pull Request #1302 · deephaven/deephaven-plugins

mofojed · 2026-02-11T22:51:01Z

Dashboard component now detects when inside a panel and delegates to NestedDashboard
NestedDashboard uses Dashboard from @deephaven/dashboard to create isolated layout
NestedDashboardContent provides context providers for nested panels
DashboardContent extracted for top-level dashboard rendering
Add E2E tests and Python test fixtures for nested dashboards
Add unit tests for Dashboard and NestedDashboard components
Updated documentation with some examples for nested dashboards, removed restrictions about nesting dashboards in panels

- Dashboard component now detects when inside a panel and delegates to NestedDashboard - NestedDashboard uses DHCDashboard from @deephaven/dashboard to create isolated GoldenLayout - NestedDashboardContent provides context providers for nested panels - DashboardContent extracted for top-level dashboard rendering - Add E2E tests and Python test fixtures for nested dashboards - Add unit tests for Dashboard and NestedDashboard components DH-19818

- Just using usePersistentState and it seems to work - Sometimes the nested dashboards don't load correctly, seems to be an intermittent issue/some sort of race condition. Will debug later, after writing docs

- Update rules to clarify root-level vs nested dashboard restrictions - Update bottom-level section to reference nested dashboards - Add Nested Dashboards section with examples to dashboard.md - Add Nested Dashboards section to creating-dashboards.md guide - Add example for sharing state between nested dashboards

github-actions · 2026-02-12T18:09:57Z

ui docs preview (Available for 14 days)

- Separated into its own PR: deephaven#1303

github-actions · 2026-02-12T18:16:13Z

ui docs preview (Available for 14 days)

dsmmcken · 2026-02-17T19:01:54Z

plugins/ui/docs/components/dashboard.md


+## Nested Dashboards
+
+Dashboards can be nested inside panels to create complex layouts with isolated drag-and-drop regions. Each nested dashboard creates its own independent layout that users can rearrange without affecting the parent dashboard.


Do we need an enterprise only note that dashboards not defined at root won't appear in the shared dashboards list?

Hmm well the dashboard doesn't have a name... but yea I'll make that clear. In DHC it won't appear in your panels list either.

plugins/ui/docs/components/dashboard.md

plugins/ui/docs/creating-layouts/creating-dashboards.md

plugins/ui/docs/components/dashboard.md

…oards

github-actions · 2026-02-18T15:29:34Z

ui docs preview (Available for 14 days)

jnumainville

Not much python to review here (which is a good thing) so took a quick look at JS and docs too

plugins/ui/docs/creating-layouts/creating-dashboards.md

plugins/ui/src/js/src/layout/NestedDashboard.test.tsx

github-actions · 2026-02-23T19:20:38Z

ui docs preview (Available for 14 days)

vbabich · 2026-02-24T21:07:25Z

Found these issues while testing:

Opening a nested dashboard via the New Tab screen opens the dashboard with empty content
Copying a nested dashboard via the tab context menu -> Make a Copy creates a copy with empty content

mofojed · 2026-02-25T15:53:10Z

Found these issues while testing:

Opening a nested dashboard via the New Tab screen opens the dashboard with empty content

Copying a nested dashboard via the tab context menu -> Make a Copy creates a copy with empty content

Both of those empty content issues are reproducible in Core by just deselecting "Close Panels on Disconnect", creating a simple nested dashboard and opening, and then refreshing:

from deephaven import ui

d = ui.panel(
    ui.dashboard(
        ui.row(
            ui.panel(ui.text("Content A"), title="Panel A"),
            ui.panel(ui.text("Content B"), title="Panel B")
        )
    )
)

- Was trying to re-open the layout after it was already set in the layout config - Just don't set the layout config, that's how we handle other deephaven.ui dashboards - The widget state is still preserved, so input/filters set within nested dashboards still is preserved - There still seems to be an intermittent issue where sometimes when opening a nested dashboard, it displays incorrectly (just an empty black square)

github-actions · 2026-02-25T17:16:32Z

ui docs preview (Available for 14 days)

github-actions · 2026-02-25T19:16:10Z

ui docs preview (Available for 14 days)

- Pass down the __dhId correctly to the NestedDashboardContent - That's what's calling the usePersistentState, so that's what needs the dhId set - Don't register event listeners from nested DashboardPlugin - Just need to register the PortalPanel stuff

github-actions · 2026-02-25T21:14:11Z

ui docs preview (Available for 14 days)

mofojed · 2026-02-26T14:18:11Z

@vbabich those issues observed should now be fixed. bender-dh-19818 is up to date.

vbabich

Looks good!

vbabich · 2026-03-03T19:21:53Z

tests/ui_nested_dashboard.spec.ts

+    await expect(outerPanel.getByText('Deepest Content')).toBeVisible();
+  });
+
+  test('nested dashboard resizes with parent panel', async ({ page }) => {


This test doesn't seem to test what it claims, either delete or update.

vbabich · 2026-03-03T21:27:56Z

plugins/ui/src/js/src/layout/usePanelManager.ts

+      // We do it outside of the `handleClose` function in case a new panel opens up in the same render cycle
+      log.debug2(
+        'Widget',
+        widget.id,
+        'open panel count',
+        panelIds.current.length
+      );
+      if (panelIds.current.length === 0) {
+        log.debug('Widget', widget.id, 'closed all panels, triggering onClose');
+        onClose?.();
+      } else {
+        onDataChange({ ...widgetData, panelIds: panelIds.current });


Looks like this is existing code moved from DocumentHandler. Could passing a mutable panelIds.current be potentially problematic?

Yea, it's not a problem yet but that's an anti-pattern. I'll copy the array first.

plugins/ui/docs/components/dashboard.md

plugins/ui/src/js/src/layout/NestedDashboard.tsx

github-actions · 2026-03-05T18:01:50Z

ui docs preview (Available for 14 days)

github-actions · 2026-03-05T18:30:16Z

ui docs preview (Available for 14 days)

margaretkennedy

one tiny nitpick!

plugins/ui/docs/components/dashboard.md

Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>

github-actions · 2026-03-06T14:55:39Z

ui docs preview (Available for 14 days)

mofojed self-assigned this Feb 11, 2026

github-actions bot requested a review from margaretkennedy February 11, 2026 22:51

mofojed added 7 commits February 12, 2026 11:00

Add styling for nested dashboards

3ed20a1

Add implementation plan for DH-19818 nested dashboards

8cf6066

feat: add Copilot Agent Skills for testing

66cef17

docs: update nested dashboards plan - remove Phase 3, update task status

3a284bd

Add persistence

2586c53

- Just using usePersistentState and it seems to work - Sometimes the nested dashboards don't load correctly, seems to be an intermittent issue/some sort of race condition. Will debug later, after writing docs

mofojed force-pushed the DH-19818-nested-dashboards branch from 1be29b1 to 6b71ddb Compare February 12, 2026 16:00

mofojed added 2 commits February 12, 2026 11:06

Cleanup TODO comment

a8cbfa7

Fix unused imports

42dec75

mofojed requested review from a team, dsmmcken, jnumainville and vbabich and removed request for a team February 12, 2026 16:21

Added docs snapshots

886bd8f

Removing skills from this PR

2ddc84f

- Separated into its own PR: deephaven#1303

mofojed mentioned this pull request Feb 17, 2026

feat: DH-19818: Nested dashboards, complex homepage layout #1238

Closed

dsmmcken requested changes Feb 17, 2026

View reviewed changes

mofojed added 2 commits February 18, 2026 10:25

Clean up based on review

b36a411

Merge remote-tracking branch 'origin/main' into DH-19818-nested-dashb…

7bc829d

…oards

mofojed requested a review from dsmmcken February 18, 2026 15:29

jnumainville requested changes Feb 18, 2026

View reviewed changes

plugins/ui/docs/creating-layouts/creating-dashboards.md Outdated Show resolved Hide resolved

plugins/ui/docs/creating-layouts/creating-dashboards.md Outdated Show resolved Hide resolved

plugins/ui/src/js/src/layout/NestedDashboard.test.tsx Outdated Show resolved Hide resolved

mofojed requested a review from jnumainville February 23, 2026 20:59

margaretkennedy previously approved these changes Feb 23, 2026

View reviewed changes

jnumainville previously approved these changes Feb 23, 2026

View reviewed changes

mofojed dismissed stale reviews from jnumainville and margaretkennedy via e3d3023 February 25, 2026 17:13

Fix unit tests

cd7d1bc

vbabich reviewed Mar 4, 2026

View reviewed changes

Cleanup based on review

dea00df

Remove useless test

1c8a276

vbabich previously approved these changes Mar 5, 2026

View reviewed changes

jnumainville previously approved these changes Mar 5, 2026

View reviewed changes

margaretkennedy reviewed Mar 5, 2026

View reviewed changes

plugins/ui/docs/components/dashboard.md Outdated Show resolved Hide resolved

Update plugins/ui/docs/components/dashboard.md

7e5843e

Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>

mofojed dismissed stale reviews from jnumainville and vbabich via 7e5843e March 6, 2026 14:52

mofojed enabled auto-merge (squash) March 6, 2026 14:52

mofojed requested a review from margaretkennedy March 6, 2026 14:53

margaretkennedy approved these changes Mar 6, 2026

View reviewed changes


		## Nested Dashboards

		Dashboards can be nested inside panels to create complex layouts with isolated drag-and-drop regions. Each nested dashboard creates its own independent layout that users can rearrange without affecting the parent dashboard.

Conversation

mofojed commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

Uh oh!

dsmmcken Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

mofojed Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

jnumainville left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 23, 2026

Uh oh!

vbabich commented Feb 24, 2026

Uh oh!

mofojed commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

mofojed commented Feb 26, 2026

Uh oh!

vbabich left a comment

Choose a reason for hiding this comment

Uh oh!

vbabich Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

mofojed Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

vbabich Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

mofojed Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

margaretkennedy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mofojed commented Feb 11, 2026 •

edited

Loading

jnumainville left a comment •

edited

Loading