feat: DH-21183: Add Context Menu on Pivot ColumnBy sources#1327
Open
vbabich wants to merge 3 commits intodeephaven:mainfrom
Open
feat: DH-21183: Add Context Menu on Pivot ColumnBy sources#1327vbabich wants to merge 3 commits intodeephaven:mainfrom
vbabich wants to merge 3 commits intodeephaven:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated context menu for Pivot “columnBy source” headers (negative column indexes), enabling users to sort/filter/copy from those source headers while suppressing menus on non-source grouped headers.
Changes:
- Introduces
PivotContextMenuHandlerto build and trigger context-menu actions (sort, filter, copy) for pivot column source headers. - Adds comprehensive Jest coverage for context menu behavior and action generation.
- Registers the new handler via
usePivotMouseHandlers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
plugins/pivot/src/js/src/PivotContextMenuHandler.ts |
New grid mouse handler that triggers a context menu on pivot column source headers and wires sort/filter/copy actions. |
plugins/pivot/src/js/src/PivotContextMenuHandler.test.ts |
New unit tests covering context-menu triggering/suppression and action behavior for sort/filter/copy. |
plugins/pivot/src/js/src/hooks/usePivotMouseHandlers.ts |
Adds the new context-menu handler to the pivot grid mouse handlers list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgodinez-dh
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.