Skip to content

feat: DH-21183: Add Context Menu on Pivot ColumnBy sources#1327

Open
vbabich wants to merge 3 commits intodeephaven:mainfrom
vbabich:vlad_dh-21183
Open

feat: DH-21183: Add Context Menu on Pivot ColumnBy sources#1327
vbabich wants to merge 3 commits intodeephaven:mainfrom
vbabich:vlad_dh-21183

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Apr 2, 2026

No description provided.

@vbabich vbabich marked this pull request as ready for review April 2, 2026 18:23
@vbabich vbabich requested a review from Copilot April 2, 2026 18:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a dedicated context menu for Pivot “columnBy source” headers (negative column indexes), enabling users to sort/filter/copy from those source headers while suppressing menus on non-source grouped headers.

Changes:

  • Introduces PivotContextMenuHandler to build and trigger context-menu actions (sort, filter, copy) for pivot column source headers.
  • Adds comprehensive Jest coverage for context menu behavior and action generation.
  • Registers the new handler via usePivotMouseHandlers.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
plugins/pivot/src/js/src/PivotContextMenuHandler.ts New grid mouse handler that triggers a context menu on pivot column source headers and wires sort/filter/copy actions.
plugins/pivot/src/js/src/PivotContextMenuHandler.test.ts New unit tests covering context-menu triggering/suppression and action behavior for sort/filter/copy.
plugins/pivot/src/js/src/hooks/usePivotMouseHandlers.ts Adds the new context-menu handler to the pivot grid mouse handlers list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vbabich vbabich self-assigned this Apr 2, 2026
@vbabich vbabich requested review from a team and dgodinez-dh and removed request for a team April 2, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants