[Build] Fix SCALAPACK LIBRARY find logic#7214
Merged
mohanchen merged 3 commits intodeepmodeling:developfrom Apr 7, 2026
Merged
[Build] Fix SCALAPACK LIBRARY find logic#7214mohanchen merged 3 commits intodeepmodeling:developfrom
mohanchen merged 3 commits intodeepmodeling:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the top-level CMake configuration to allow users to provide a ScaLAPACK directory or full library path directly, avoiding an unconditional find_package(ScaLAPACK REQUIRED) failure in environments where ScaLAPACK isn’t discoverable by CMake.
Changes:
- Add a
SCALAPACK_LIBRARY_DIRoverride path that skipsfind_package(ScaLAPACK)when provided. - If
SCALAPACK_LIBRARY_DIRis a directory, attempt to locatescalapackviafind_library()and fail fast if not found. - If
USE_DSPis enabled and no ScaLAPACK path is provided, emit a clear configuration-time error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Cstandardlib
changed the title
mohanchen
approved these changes
Apr 7, 2026
Collaborator
|
LGTM |
mohanchen
added
the
Compile & CICD & Docs & Dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #7213
What's changed?
find_packageif the path is given.