[Tests] Add test for small cell#7216
Open
Cstandardlib wants to merge 7 commits intodeepmodeling:developfrom
Open
[Tests] Add test for small cell#7216Cstandardlib wants to merge 7 commits intodeepmodeling:developfrom
Cstandardlib wants to merge 7 commits intodeepmodeling:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new SDFT regression test case targeting very small (high-density) cells to cover the “small cell” scenario discussed in #7170 / #7023 (related to the mxr/Ewald changes in #7036).
Changes:
- Register the new CPU SDFT case in
tests/06_SDFT/CASES_CPU.txt. - Add a new test directory
24_PW_SDFT_SMALL_CELL/withINPUT,KPT,STRU,result.ref, and a briefREADME.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/06_SDFT/CASES_CPU.txt | Adds the new 24_PW_SDFT_SMALL_CELL case to the CPU SDFT test list. |
| tests/06_SDFT/24_PW_SDFT_SMALL_CELL/INPUT | Defines a small-cell SDFT SCF run configuration (PW basis, stress/force enabled). |
| tests/06_SDFT/24_PW_SDFT_SMALL_CELL/KPT | Provides a small k-point mesh for the case. |
| tests/06_SDFT/24_PW_SDFT_SMALL_CELL/STRU | Defines the small-cell deuterium structure and pseudopotential reference. |
| tests/06_SDFT/24_PW_SDFT_SMALL_CELL/result.ref | Adds reference values used by the integration test harness. |
| tests/06_SDFT/24_PW_SDFT_SMALL_CELL/README | One-line description of the test purpose. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #7170
Add tests for #7023, #7036
Unit Tests and/or Case Tests for my changes