build(pyproject): adopt PEP 639 license metadata#5380
build(pyproject): adopt PEP 639 license metadata#5380njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
Conversation
Use SPDX license expression and add license-files. Bump scikit-build-core minimum to 0.11 for PEP 639 support. Remove deprecated license classifier. Authored by OpenClaw (model: gpt-5.4)
📝 WalkthroughWalkthroughUpdated pyproject.toml with scikit-build-core minimum version requirement bumped to >=0.11, changed license metadata from file reference to SPDX identifier 'LGPL-3.0-or-later', added license-files configuration, and removed corresponding license classifier. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
182-184: Consider updatingminimum-versionfor consistency.The
[tool.scikit-build]section specifiesminimum-version = "0.5", but the build-system now requires>=0.11. While this isn't a functional issue (the build-system constraint takes precedence), updatingminimum-versionto"0.11"would maintain consistency and clearly signal the config's intended compatibility.♻️ Suggested change
[tool.scikit-build] experimental = true -minimum-version = "0.5" +minimum-version = "0.11"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` around lines 182 - 184, Update the [tool.scikit-build] config's minimum-version value to match the build-system requirement by changing minimum-version from "0.5" to "0.11" so the pyproject.toml is consistent; locate the [tool.scikit-build] section and set minimum-version = "0.11" (the symbol to edit is minimum-version in the [tool.scikit-build] block).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Around line 182-184: Update the [tool.scikit-build] config's minimum-version
value to match the build-system requirement by changing minimum-version from
"0.5" to "0.11" so the pyproject.toml is consistent; locate the
[tool.scikit-build] section and set minimum-version = "0.11" (the symbol to edit
is minimum-version in the [tool.scikit-build] block).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5380 +/- ##
==========================================
- Coverage 82.38% 82.38% -0.01%
==========================================
Files 812 812
Lines 83611 83611
Branches 4091 4090 -1
==========================================
- Hits 68882 68881 -1
- Misses 13508 13509 +1
Partials 1221 1221 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use SPDX license expression:
LGPL-3.0-or-laterAdd license-files.
Bump scikit-build-core minimum to 0.11 for PEP 639 support.
Authored by OpenClaw (model: gpt-5.4)
Summary by CodeRabbit