Skip to content

build(pyproject): adopt PEP 639 license metadata#5380

Open
njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
njzjz-bothub:openclaw/pep639-license
Open

build(pyproject): adopt PEP 639 license metadata#5380
njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
njzjz-bothub:openclaw/pep639-license

Conversation

@njzjz-bot
Copy link
Copy Markdown
Contributor

@njzjz-bot njzjz-bot commented Apr 6, 2026

Use SPDX license expression: LGPL-3.0-or-later
Add license-files.
Bump scikit-build-core minimum to 0.11 for PEP 639 support.

Authored by OpenClaw (model: gpt-5.4)

Summary by CodeRabbit

  • Chores
    • Updated build system dependencies to use scikit-build-core version 0.11 or later.
    • Clarified project license declaration as LGPL-3.0-or-later.

Use SPDX license expression and add license-files.
Bump scikit-build-core minimum to 0.11 for PEP 639 support.
Remove deprecated license classifier.

Authored by OpenClaw (model: gpt-5.4)
@dosubot dosubot bot added the build label Apr 6, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

Updated pyproject.toml with scikit-build-core minimum version requirement bumped to >=0.11, changed license metadata from file reference to SPDX identifier 'LGPL-3.0-or-later', added license-files configuration, and removed corresponding license classifier.

Changes

Cohort / File(s) Summary
Configuration Update
pyproject.toml
Bumped scikit-build-core minimum version from 0.5 to 0.11, reformatted license from file reference to SPDX identifier 'LGPL-3.0-or-later', added license-files declaration, and removed LGPLv3 license classifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build(pyproject): adopt PEP 639 license metadata' accurately and specifically describes the main objective of the pull request, which is to adopt PEP 639 license metadata in pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
pyproject.toml (1)

182-184: Consider updating minimum-version for consistency.

The [tool.scikit-build] section specifies minimum-version = "0.5", but the build-system now requires >=0.11. While this isn't a functional issue (the build-system constraint takes precedence), updating minimum-version to "0.11" would maintain consistency and clearly signal the config's intended compatibility.

♻️ Suggested change
 [tool.scikit-build]
 experimental = true
-minimum-version = "0.5"
+minimum-version = "0.11"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pyproject.toml` around lines 182 - 184, Update the [tool.scikit-build]
config's minimum-version value to match the build-system requirement by changing
minimum-version from "0.5" to "0.11" so the pyproject.toml is consistent; locate
the [tool.scikit-build] section and set minimum-version = "0.11" (the symbol to
edit is minimum-version in the [tool.scikit-build] block).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@pyproject.toml`:
- Around line 182-184: Update the [tool.scikit-build] config's minimum-version
value to match the build-system requirement by changing minimum-version from
"0.5" to "0.11" so the pyproject.toml is consistent; locate the
[tool.scikit-build] section and set minimum-version = "0.11" (the symbol to edit
is minimum-version in the [tool.scikit-build] block).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ad4386a4-8237-4529-868d-c792b00d8176

📥 Commits

Reviewing files that changed from the base of the PR and between efc27cf and 9588a8f.

📒 Files selected for processing (1)
  • pyproject.toml

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.38%. Comparing base (efc27cf) to head (9588a8f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5380      +/-   ##
==========================================
- Coverage   82.38%   82.38%   -0.01%     
==========================================
  Files         812      812              
  Lines       83611    83611              
  Branches     4091     4090       -1     
==========================================
- Hits        68882    68881       -1     
- Misses      13508    13509       +1     
  Partials     1221     1221              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@njzjz njzjz requested a review from wanghan-iapcm April 7, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant