Raise error when from_deepmd_npy_mixed with not-a-directory para.#432
Open
iProzd wants to merge 2 commits intodeepmodeling:masterfrom
Open
Raise error when from_deepmd_npy_mixed with not-a-directory para.#432iProzd wants to merge 2 commits intodeepmodeling:masterfrom
iProzd wants to merge 2 commits intodeepmodeling:masterfrom
Conversation
…not-a-directory para.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 82.51% 82.53% +0.02%
==========================================
Files 68 68
Lines 6198 6206 +8
==========================================
+ Hits 5114 5122 +8
Misses 1084 1084 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wanghan-iapcm
requested changes
Mar 13, 2023
|
|
||
| def from_multi_systems(self, directory, **kwargs): | ||
| sys_dir = [] | ||
| assert os.path.isdir(directory), f"{directory} is not a directory!" |
Contributor
There was a problem hiding this comment.
Please raise FileNotFoundError. One has not chance of catching the error with assertion!
Plz also add a UT for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.