feat(collections/unstable): have zip accept Iterable#7120
Open
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Open
feat(collections/unstable): have zip accept Iterable#7120tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
zip accept Iterable#7120tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Conversation
Mirrors the iterable-based `interleave` API so `zip` can accept any `Iterable`, not just arrays. Non-array iterables are consumed eagerly via `Array.from`, then the existing index-based zip-to-shortest logic runs. Adds a two-iterable fast path matching `interleave`. Lives alongside stable `zip` to bake before any decision about replacing the stable version. Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7120 +/- ##
=======================================
Coverage 94.61% 94.61%
=======================================
Files 634 635 +1
Lines 51801 51829 +28
Branches 9329 9338 +9
=======================================
+ Hits 49011 49038 +27
Misses 2216 2216
- Partials 574 575 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interleaveAPI sozipcan accept anyIterable, not just arrays.Array.from, then the existing index-based zip-to-shortest logic runs.interleave.