fix(yaml): tighten parse() and parseAll() types#7125
Open
tomas-zijdemans wants to merge 3 commits intodenoland:mainfrom
Open
fix(yaml): tighten parse() and parseAll() types#7125tomas-zijdemans wants to merge 3 commits intodenoland:mainfrom
parse() and parseAll() types#7125tomas-zijdemans wants to merge 3 commits intodenoland:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7125 +/- ##
==========================================
- Coverage 94.61% 94.61% -0.01%
==========================================
Files 634 634
Lines 51801 51805 +4
Branches 9329 9329
==========================================
+ Hits 49011 49013 +2
- Misses 2216 2218 +2
Partials 574 574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(yaml): tighten parse() and parseAll() types
parseAll()is typedunknown[]to match its implementation.ParseOptions.onWarningis narrowed fromErrortoSyntaxError, matching what the loader actually dispatches.@throws {SyntaxError}is documented onparseAll(), andparse()'s@throwsclarifies the multi-document case.Mirrored in
unstable_parse.ts. All changes are non-breaking by subtyping (unknown[]⊆unknown) and function-parameter contravariance ((Error) => voidis assignable to(SyntaxError) => void).